Skip to content

Reintroduce build time init of compilation time metadata #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 10, 2024

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented Jul 5, 2024

This PR reintroduces build time initialisation of compilation time metadata that was removed in 4.5.0

The changes allow Micronaut to support --strict-image-heap whilst still optimising for build time initialisation.

To achieve this evaluated expressions are now initialised at build time. This is safe because these cannot feature static initialisers. In addition enum introspections now no longer reference the enum values but lazily evaluate these.

@graemerocher graemerocher marked this pull request as ready for review July 8, 2024 09:52
@graemerocher graemerocher requested a review from dstepanov July 8, 2024 09:52
@graemerocher graemerocher force-pushed the reintroduce-buildtime-init branch from db04570 to 1284168 Compare July 8, 2024 12:09
@graemerocher graemerocher marked this pull request as draft July 8, 2024 14:15
@graemerocher graemerocher force-pushed the reintroduce-buildtime-init branch from 3643c0c to 532b15a Compare July 9, 2024 13:54
@graemerocher graemerocher changed the title Reintroduce build time init of metadata Reintroduce build time init of compilation time metadata Jul 9, 2024
@graemerocher graemerocher marked this pull request as ready for review July 9, 2024 13:59
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
43.2% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@graemerocher graemerocher merged commit ba0e749 into 4.6.x Jul 10, 2024
16 of 17 checks passed
@graemerocher graemerocher deleted the reintroduce-buildtime-init branch July 10, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants