Use MatchArgumentQualifier for DefaultMessageBodyHandlerRegistry
#10964
+237
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there tests that cover this behaviour? Probably yes because some are failing |
|
I need to investigate |
yawkat
requested changes
Jul 10, 2024
http/src/main/java/io/micronaut/http/body/DefaultMessageBodyHandlerRegistry.java
Outdated
Show resolved
Hide resolved
inject/src/main/java/io/micronaut/inject/qualifiers/MatchArgumentQualifier.java
Outdated
Show resolved
Hide resolved
graemerocher
requested changes
Jul 10, 2024
inject/src/main/java/io/micronaut/inject/qualifiers/MatchArgumentQualifier.java
Show resolved
Hide resolved
| * @param <T> The bean type | ||
| * @return The qualifier | ||
| */ | ||
| public static <T> MatchArgumentQualifier<T> contravariant(Class<T> beanType, Argument<?> genericArgument) { |
There was a problem hiding this comment.
add nullability annotations
| * Use-cases are generic deserializers, readers. | ||
| * Java example: | ||
| * MyReader[ArrayList[String]] candidate = ...; | ||
| * MyReader[? extends List[String]] aMatch = candidate; |
There was a problem hiding this comment.
can you add @since here and wrap the code snippets in <pre><code> tags
There was a problem hiding this comment.
Add the code tag, since is not needed because the class is new in this version
inject/src/main/java/io/micronaut/inject/qualifiers/MatchArgumentQualifier.java
Outdated
Show resolved
Hide resolved
yawkat
approved these changes
Jul 10, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.