Correct reading HTTP client response body without content type + ByteBuffer converters
#10975
+287
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepanov
changed the title
ByteBuffer converters
yawkat
reviewed
Jul 12, 2024
| conversionService.addConverter( | ||
| java.nio.ByteBuffer.class, | ||
| ByteBuf.class, | ||
| nioBuffer -> Unpooled.copiedBuffer(nioBuffer) |
yawkat
reviewed
Jul 12, 2024
| } | ||
| }); | ||
| if (res instanceof FullNettyClientHttpResponse response) { | ||
| response.onComplete(); |
There was a problem hiding this comment.
are you sure we don't need the onComplete here
yawkat
reviewed
Jul 12, 2024
| @@ -1447,7 +1432,6 @@ public void onComplete() { | |||
| try { | |||
| FullHttpResponse fullHttpResponse = new DefaultFullHttpResponse(nettyResponse.protocolVersion(), nettyResponse.status(), buffer, nettyResponse.headers(), new DefaultHttpHeaders(true)); | |||
| final FullNettyClientHttpResponse<Object> fullNettyClientHttpResponse = new FullNettyClientHttpResponse<>(fullHttpResponse, handlerRegistry, (Argument<Object>) errorType, true, conversionService); | |||
| fullNettyClientHttpResponse.onComplete(); | |||
yawkat
reviewed
Jul 12, 2024
|
|
||
| @Override | ||
| public void onComplete() { | ||
| this.complete = true; |
There was a problem hiding this comment.
Yeah, the field was highlighted as not used
yawkat
approved these changes
Jul 12, 2024
|
graemerocher
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer of the client response should be discarded