Improvements to HTTP client timeout handling #10983
Merged
+366
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yawkat
commented
Jul 16, 2024
yawkat
commented
- Introduce new config properties to automatically send HTTP/2 pings on idle connections
- Introduce a new request-timeout property for the high-level timeout
- Remove ResettableReadTimeoutHandler now that it's upstream
- Adjust documentation of read-idle-timeout to match actual behavior (does not apply to streaming requests), add note to rename in 5.0
- Add note to event loop executor properties
- Introduce new config properties to automatically send HTTP/2 pings on idle connections - Introduce a new request-timeout property for the high-level timeout - Remove ResettableReadTimeoutHandler now that it's upstream - Adjust documentation of read-idle-timeout to match actual behavior (does not apply to streaming requests), add note to rename in 5.0 - Add note to event loop executor properties
dstepanov
reviewed
Jul 16, 2024
http-client-core/src/main/java/io/micronaut/http/client/HttpClientConfiguration.java
Outdated
Show resolved
Hide resolved
graemerocher
requested changes
Jul 18, 2024
http-client-core/src/main/java/io/micronaut/http/client/HttpClientConfiguration.java
Show resolved
Hide resolved
http-client-core/src/main/java/io/micronaut/http/client/HttpClientConfiguration.java
Outdated
Show resolved
Hide resolved
| * @since 4.6.0 | ||
| */ | ||
| @Nullable | ||
| public Http2Configuration getHttp2Configuration() { |
There was a problem hiding this comment.
maybe return Optional<Http2Configuration>
There was a problem hiding this comment.
I am matching what getWebSocketCompressionConfiguration does here
http-client-core/src/main/java/io/micronaut/http/client/HttpClientConfiguration.java
Outdated
Show resolved
Hide resolved
http-client-core/src/main/java/io/micronaut/http/client/HttpClientConfiguration.java
Outdated
Show resolved
Hide resolved
| * The service HTTP/2 configuration. | ||
| */ | ||
| @ConfigurationProperties(WebSocketCompressionConfiguration.PREFIX) | ||
| public static class ServiceHttp2Configuration extends Http2Configuration { |
There was a problem hiding this comment.
does this need to be @BootstrapCompatible?
There was a problem hiding this comment.
I don't know. The other subconfigs arent either
http-client/src/main/java/io/micronaut/http/client/netty/Http2PingSender.java
Show resolved
Hide resolved
|
graemerocher
approved these changes
Jul 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.