imp: handle errors via standard mechanism - exceptions and error handlers #11080
+831
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
changed the title
sdelamo
changed the title
dstepanov
approved these changes
Aug 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #11070
This PR superseeds #11070
@dstepanov
The main difference with #11070 is to move the status and message logic to individual exceptions and handlers. This PR adds:
NotFoundExceptionNotAllowedExceptionNotAcceptableExceptionNotWebSocketRequestExceptionUnsupportedMediaExceptionThese exceptions are
HttpStatusExceptions. These granularity gives users more flexibility. E.g. you may want to create your ownNotFoundExceptionHandlerto respond a HTML Page but you don't care about custom handlers for the other exceptions.