Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with multiple factories of the same type with distinct qualifiers #7537

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented Jun 1, 2022

A type element visitor can define multiple factories of the same type with different qualifiers. This leads to a NonUniqueBeanException since qualifiers are not factored in when looking up the factory. This fixes that.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…iers
@graemerocher graemerocher requested a review from dstepanov June 1, 2022 15:13
@graemerocher graemerocher added this to the 3.5.1 milestone Jun 1, 2022
@graemerocher graemerocher requested a review from sdelamo June 1, 2022 15:13
@graemerocher graemerocher added the type: bug Something isn't working label Jun 1, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

93.2% 93.2% Coverage
7.4% 7.4% Duplication

@sdelamo sdelamo merged commit c6b8ec2 into 3.5.x Jun 2, 2022
@sdelamo sdelamo deleted the multiple-factory-issue branch June 2, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants