Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jackson to 2.15.0 #9150

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Update jackson to 2.15.0 #9150

merged 3 commits into from
Apr 25, 2023

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Apr 24, 2023

No description provided.

@yawkat yawkat requested a review from sdelamo April 24, 2023 09:27
@yawkat
Copy link
Member Author

yawkat commented Apr 24, 2023

@melix can you take a look at the failure? i removed the managed-jackson-databind version and use managed-jackson again, and I think that's the issue. But it should be safe.

@melix
Copy link
Contributor

melix commented Apr 24, 2023

The failure is expected. If a user for some reason uses mn.versions.jackson.databind in their build script, then this change would break it. I would recommend to keep both versions since it's a 3.x fix and we're not supposed to break things. It's an ok change for master though.

@yawkat
Copy link
Member Author

yawkat commented Apr 24, 2023

ok thanks

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo merged commit a9f64ff into 3.10.x Apr 25, 2023
@sdelamo sdelamo deleted the jackson215 branch April 25, 2023 10:16
@sdelamo sdelamo added the type: dependency-upgrade Upgrade a dependency label Apr 25, 2023
@yawkat
Copy link
Member Author

yawkat commented Apr 25, 2023

@sdelamo can you merge this up to 4.x soonish, i want to make some optimizations using 2.15 changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants