Another HTTP filters refactoring #9722
Merged
+1,310
−1,015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepanov
force-pushed
the
filtref
branch
2 times, most recently
from
36c6a0f to
37b9bad
Compare
yawkat
requested changes
Aug 22, 2023
...ient-core/src/main/java/io/micronaut/http/client/filter/DefaultHttpClientFilterResolver.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public ExecutionFlow<FilterContext> processRequestFilter(FilterContext context, | ||
| Function<FilterContext, ExecutionFlow<FilterContext>> downstream) { |
There was a problem hiding this comment.
maybe this should be a dedicated interface
There was a problem hiding this comment.
Gonna leave it for now
router/src/main/java/io/micronaut/web/router/DefaultFilterRoute.java
Outdated
Show resolved
Hide resolved
router/src/test/groovy/io/micronaut/web/router/DefaultFilterRouteSpec.groovy
Outdated
Show resolved
Hide resolved
router/src/test/groovy/io/micronaut/web/router/DefaultFilterRouteSpec.groovy
Outdated
Show resolved
Hide resolved
router/src/test/groovy/io/micronaut/web/router/DefaultFilterRouteSpec.groovy
Outdated
Show resolved
Hide resolved
yawkat
approved these changes
Aug 22, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9720 I found it's a bit complicated to maintain that code, refactoring to split the main filter runner into multiple classes. Avoid if-instanceof, converted most of the code to private, separate async execution.
Targeting 4.2