Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KSP: Cache overridee #9753

Merged
merged 2 commits into from Aug 21, 2023
Merged

KSP: Cache overridee #9753

merged 2 commits into from Aug 21, 2023

Conversation

dstepanov
Copy link
Contributor

Attempt to fix #9750

@dstepanov dstepanov changed the base branch from 4.1.x to 4.0.x August 21, 2023 12:47
@graemerocher
Copy link
Contributor

need confirmation it works

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

72.4% 72.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dstepanov
Copy link
Contributor Author

What do you mean? We can validate the improvement after the release

@dstepanov dstepanov added the type: improvement A minor improvement to an existing feature label Aug 21, 2023
@dstepanov dstepanov added this to the 4.0.6 milestone Aug 21, 2023
@dstepanov dstepanov merged commit 665004f into 4.0.x Aug 21, 2023
7 of 8 checks passed
@dstepanov dstepanov deleted the kspcache branch August 21, 2023 13:39
sdelamo added a commit that referenced this pull request Aug 24, 2023
@sdelamo @dstepanov
Merge up 4.0.x into 4.1.x (#9761)
1fc06d7 
* KSP: Cache overridee (#9753)

* KSP: Cache overridee

* Correct

* Correct type arguments for introduces beans (#9752)

---------

Co-authored-by: Denis Stepanov <denis.s.stepanov@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Milestone
4.0.6
Development

Successfully merging this pull request may close these issues.

KSP: Performance regression after migration to KSP
2 participants
@dstepanov @graemerocher