Improve default annotation values #9838
Merged
+451
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
yawkat
reviewed
Sep 11, 2023
| * @return The annotation default values | ||
| */ | ||
| @NonNull | ||
| Map<CharSequence, Object> provide(String annotationName); |
There was a problem hiding this comment.
Why CharSequence instead of String?
CS doesn't have a well-defined eq/hc
There was a problem hiding this comment.
Not really sure, we have it everywere
There was a problem hiding this comment.
CharSequence is parent of both Java's String and Groovy's GString.
There was a problem hiding this comment.
that means we need it for the processor i guess, but maybe we can move to String on the runtime side
|
@graemerocher Pls also check |
graemerocher
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Core annotations default values to prevent repeating them in bean definitions.
Fixed a bug with missing defaults for nested annotations.
Changed for
AnnotationValuesto have default values fetched lazily, preventing additional calls to the concurrent map during the class init.We might want to remove additional calls to fill
Map<String, Class<? extends Annotation>> ANNOTATION_TYPESand make that resolution at the runtime. In don't thinkAnnotationMetadataOptional<Class<? extends Annotation>> getAnnotationType(@NonNull String name)is very much used.