Adds kotlin-ext-fns guide and sample code #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilopmar
suggested changes
Mar 22, 2021
There was a problem hiding this comment.
Looks good, I've only added some minor things.
One question @willbuck, did you try it with GraalVM? I'm asking because I'm not sure if DadJoke needs to be annotated with @Introspected or not. In a Java app we put the annotation but I'm not sure in a Kotlin data class.
guides/micronaut-kotlin-extension-fns/kotlin/src/test/kotlin/example/micronaut/DadJokeTest.kt
Outdated
Show resolved
Hide resolved
guides/micronaut-kotlin-extension-fns/kotlin/src/test/kotlin/example/micronaut/DadJokeTest.kt
Show resolved
Hide resolved
guides/micronaut-kotlin-extension-fns/micronaut-kotlin-extension-fns.adoc
Outdated
Show resolved
Hide resolved
added 2 commits
March 22, 2021 11:19
guides/micronaut-kotlin-extension-fns/micronaut-kotlin-extension-fns.adoc
Outdated
Show resolved
Hide resolved
ilopmar
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open to feedback on this one, first guide I've written in awhile!
Note that the link to the dokka docs is broken but I am working on fixing that in the kotlin repo:
micronaut-projects/micronaut-kotlin#78