Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization to java 21 #594

Merged
merged 10 commits into from Oct 18, 2023
Merged

Serialization to java 21 #594

merged 10 commits into from Oct 18, 2023

Conversation

timyates
Copy link
Member

@timyates timyates commented Oct 6, 2023

No description provided.

@timyates timyates self-assigned this Oct 6, 2023
@sdelamo sdelamo marked this pull request as ready for review October 6, 2023 14:32
sdelamo
sdelamo requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a module which is shared by both kotlin implementations to avoid duplicating tests.

@sdelamo sdelamo mentioned this pull request Oct 11, 2023
Closed
@timyates
Copy link
Member Author

I think we should have a module which is shared by both kotlin implementations to avoid duplicating tests.

We need to process the main source with a different annotation processor (so I believe that would need to be duplicated?)

Do you think it's worth duplicating the main code, but having a Test suite for the tests?

@sdelamo sdelamo mentioned this pull request Oct 11, 2023
Closed
@sdelamo sdelamo marked this pull request as draft October 17, 2023 11:31
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@timyates timyates marked this pull request as ready for review October 18, 2023 10:32
@timyates timyates requested a review from sdelamo October 18, 2023 10:34
@sdelamo sdelamo merged commit c8bb3b1 into master Oct 18, 2023
12 checks passed
@sdelamo sdelamo deleted the java-21-spike branch October 18, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

Assignees

@timyates timyates

Labels
None yet
Projects
4.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timyates @sdelamo