imp: ByteBufferSerde

[sdelamo]

Close: #603

Based on Jackson implementation:

https://github.com/FasterXML/jackson-databind/blob/2.16/src/main/java/com/fasterxml/jackson/databind/ser/std/ByteBufferSerializer.java

https://github.com/FasterXML/jackson-databind/blob/2.16/src/main/java/com/fasterxml/jackson/databind/deser/std/ByteBufferDeserializer.java

Not 100% complete see NativeTest excluded in the serde tck

[sdelamo]

This test is excluded. I don't see how to easily port this port this part of the serializer
https://github.com/FasterXML/jackson-databind/blob/2.16/src/main/java/com/fasterxml/jackson/databind/ser/std/ByteBufferSerializer.java#L27-L35

[yawkat]

since youre copying the data anyway, you can just copy it for direct buffers too. but ideally there should be overloads for encodeBinary for ByteBuffers.

[yawkat]

and what if not

[timyates]

We could take inspiration from Jackson ad do something like

diff --git a/serde-support/src/main/java/io/micronaut/serde/support/serdes/ByteBufferSerde.java b/serde-support/src/main/java/io/micronaut/serde/support/serdes/ByteBufferSerde.java
index 06e03a2f..12bc6b8d 100644
--- a/serde-support/src/main/java/io/micronaut/serde/support/serdes/ByteBufferSerde.java
+++ b/serde-support/src/main/java/io/micronaut/serde/support/serdes/ByteBufferSerde.java
@@ -58,6 +58,43 @@ public class ByteBufferSerde implements Serde<ByteBuffer> {
             byte[] copy = new byte[len];
             System.arraycopy(value.array(), offset, copy, 0, len);
             encoder.encodeBinary(copy);
+            return;
+        }
+        try (InputStream s = new ByteBufferInputStream(value.asReadOnlyBuffer().rewind())) {
+            encoder.encodeBinary(s.readAllBytes());
+        }
+    }
+
+    private static class ByteBufferInputStream extends InputStream {
+
+        private static final int EOS = -1;
+        private final ByteBuffer buffer;
+
+        private ByteBufferInputStream(ByteBuffer buffer) {
+            this.buffer = buffer;
+        }
+
+        @Override
+        public int available() {
+            return buffer.remaining();
+        }
+
+        @Override
+        public int read() {
+            if (buffer.hasRemaining()) {
+                return buffer.get() & 0xFF;
+            }
+            return EOS;
+        }
+
+        @Override
+        public int read(byte[] b, int off, int len) {
+            if (buffer.hasRemaining()) {
+                len = Math.min(len, buffer.remaining());
+                buffer.get(b, off, len);
+                return len;
+            }
+            return EOS;
         }
     }
 }

?

[timyates]

But I'm not sure my use of rewind is correct here... 🤔

[sdelamo]

adding the following commit efe6b37

[yawkat]

theres easier ways, i will look at it tomorrow.

[yawkat]

ive implemented a smaller copy mechanism. also i discovered a jackson-databind bug which might break the tck: FasterXML/jackson-databind#4164

[sdelamo]

@timyates can you review and approve. I cannot since I created the PR

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

2.1% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint