Support @JsonTypeInfo(visible=true)
#638
Conversation
dstepanov
commented
Nov 2, 2023
•
dstepanov
commented
- which allows for the deserializer to set the type discriminator as an ordinary property
| @@ -212,6 +220,15 @@ Decoder consume() { | |||
| } | |||
| } | |||
|
|
|||
| Decoder buffer() throws IOException { | |||
There was a problem hiding this comment.
how can this work, you cant use the Decoder returned by decodeBuffer multiple times
| throw new IllegalStateException("Already drained"); | ||
| } | ||
| complete = true; | ||
| // No-op: Allow to read multiple times |
There was a problem hiding this comment.
ohhhhhh. no we should definitely not allow this. it will break with more efficient implementations.
There was a problem hiding this comment.
Yeah, maybe we can allow to clone the buffer
|
ive modified it slightly, internally it's very similar (still JsonNode) but i've moved the "duplication logic" to the demuxing decoder and only apply it to the property where it's necessary. In other cases I still use normal decodeBuffer. The reason for this change is that I want to avoid expanding the contract for decodeBuffer. Right now, decodeBuffer does not permit "aliasing": It does not allow two decodeXYZ calls to the same value, even if it's been buffered at some point. This guarantee may be helpful in the future for efficiency improvements such as lazy decoding, jackson TokenBuffer etc. |
serde-api/src/main/java/io/micronaut/serde/config/annotation/SerdeConfig.java
Outdated
Show resolved
Hide resolved
…erdeConfig.java Co-authored-by: Jonas Konrad <jonas.konrad@oracle.com>
|
SonarCloud Quality Gate failed.
|
|
@dstepanov when you planned release these changes? Want also add fix in micronaut-openapi for version 5.2.0 |
|
Probably with 4.2 platform release next week |
