Fix requirement to access ObjectSerializer and incorrect caching argument DeserBean/SerBean
#653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gument `DeserBean`/`SerBean`
|
SonarCloud Quality Gate failed.
|
yawkat
approved these changes
Nov 8, 2023
| * @since 2.3.2 | ||
| */ | ||
| @Internal | ||
| public class SerdeArgumentConf { |
There was a problem hiding this comment.
can this be a record? might have to replace arrays with lists
There was a problem hiding this comment.
It's extended for now, but maybe I can improve it further.
radovanradic
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the leveled prefix/suffix are passed by extending the argument metadata.
While fixing it, I discovered our key for maps of
DeserBean/SerBeandoesn't include annotations, and that can lead to one argument configuration being used for another one.