Fix NPE when client is on classpath but not configured #656
+81
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarosanchez
approved these changes
Jul 10, 2024
Because of user errors (for example explicitly adding the test resources client even if disabled) or simply because the test resources extensions have the client as a transitive dependency, it is possible to have the test resources client present on classpath even if test resources are disabled. In that case, the client wouldn't be configurable. This commit fixes what the client returns in case there's no test resources service configured, by returning reasonable defaults instead of null. Fixes #651
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of user errors (for example explicitly adding the test resources client even if disabled) or simply because the test resources extensions have the client as a transitive dependency, it is possible to have the test resources client present on classpath even if test resources are disabled. In that case, the client wouldn't be configurable.
This commit fixes what the client returns in case there's no test resources service configured, by returning reasonable defaults instead of null.
Fixes #651