WIP: Add signed kwarg to int.to_bytes #14275
Draft
+259
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing all the work for #13087 I figured I was 99% of the way to implementing support for the
signed
kwarg, so decided to try it out. See the second commit for the changes unique to this PR.TODO
signed=True
. (Mostly results are the same, but in some cases an additional byte is needed to ensure a 0 sign bit.)signed=False
. This will be a breaking change compared to the current behaviour.as_signed
argument.Code size
Total size of unix "minimal" variant:
(Note: CI measurements are a bit worse than my measurements, see both PRs. I assume because of gcc versions.)