-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in README.md #14417
base: master
Are you sure you want to change the base?
Fix typos in README.md #14417
Conversation
Signed-off-by: tharuka <78165134+tharuka-pavith@users.noreply.github.com>
README.md
Outdated
@@ -19,7 +19,7 @@ Python 3.5 and some select features from later versions). The following core | |||
datatypes are provided: `str`(including basic Unicode support), `bytes`, | |||
`bytearray`, `tuple`, `list`, `dict`, `set`, `frozenset`, `array.array`, | |||
`collections.namedtuple`, classes and instances. Builtin modules include | |||
`os`, `sys`, `time`, `re`, and `struct`, etc. Select ports have support for | |||
`os`, `sys`, `time`, `re`, and `struct`, etc. Selected ports have support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe more clear to say "Some" or "Certain"?
"Select ports" makes more sense to me than "Selected ports" though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the feedback. I agree that Some
or Certain
could work well here. Some
would be a better choice.
Co-authored-by: David Lechner <david@lechnology.com> Signed-off-by: tharuka <78165134+tharuka-pavith@users.noreply.github.com>
Signed-off-by: tharuka <78165134+tharuka-pavith@users.noreply.github.com>
I have made following changes according to the feedback given,
Would appreciate another review. @dlech |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This handles the fix addressed in issue #14416. Following changes have been made in README.md,
Select
toSelected
in the above sentence.references
toreference
in the above sentence.