tslib v1.13.0 has breaking change #1269

- Removed Dependency on tslib
microsoft · May 29, 2020 · 6290a14 · 6290a14
1 parent 826504c
commit 6290a14
Show file tree

Hide file tree

Showing 95 changed files with 23,231 additions and 17,656 deletions.
diff --git a/.gitignore b/.gitignore
@@ -22,6 +22,7 @@
 # MSTest test Results
 [Tt]est[Rr]esult*/
 [Bb]uild[Ll]og.*
+report.*.json
 
 *_i.c
 *_p.c

diff --git a/AISKU/Tests/Selenium/Tests.html b/AISKU/Tests/Selenium/Tests.html
@@ -17,16 +17,6 @@
     <div id="qunit"></div>
     <div id="qunit-fixture"></div>
     <script>
-        function getParameterByName(name, url) {
-            if (!url) url = window.location.href;
-            name = name.replace(/[\[\]]/g, '\\$&');
-            var regex = new RegExp('[?&]' + name + '(=([^&#]*)|&|#|$)'),
-                results = regex.exec(url);
-            if (!results) return null;
-            if (!results[2]) return '';
-            return decodeURIComponent(results[2].replace(/\+/g, ' '));
-        }
-
         var modules = new ModuleLoader({
             baseUrl: '../../',
             paths: {
@@ -39,22 +29,10 @@
         // Load qunit here instead of with tests, otherwise will not work
         modules.add("qunit");
 
-        // Load whatwg-fetch
-        modules.add("whatwg-fetch").afterLoad = function (polyFetch) {
-            window.fetch = window.fetch || polyFetch.fetch;
-            window.Headers = window.Headers || polyFetch.Headers;
-            window.Response = window.Response || polyFetch.Response;
-            window.Request = window.Request || polyFetch.Request;
-            window.Promise = window.Promise || SimpleSyncPromise;
+        loadFetchModule(modules, "whatwg-fetch");
 
-            var usePolyFetch = getParameterByName("polyFetch");
-            if (usePolyFetch) {
-                window.fetch = polyFetch.fetch;
-                window.Headers = polyFetch.Headers;
-                window.Response = polyFetch.Response;
-                window.Request = polyFetch.Request;
-            }
-        };
+        // Load and define the app insights Shims module
+        modules.add("@microsoft/applicationinsights-shims", "./node_modules/@microsoft/applicationinsights-shims/browser/applicationinsights-shims");
 
         // Load Core
         modules.add("@microsoft/applicationinsights-core-js", "./node_modules/@microsoft/applicationinsights-core-js/browser/applicationinsights-core-js");

diff --git a/AISKU/package.json b/AISKU/package.json
@@ -51,13 +51,13 @@
     },
     "dependencies": {
         "@microsoft/dynamicproto-js": "^0.5.2",
+        "@microsoft/applicationinsights-shims" : "1.0.0",
         "@microsoft/applicationinsights-analytics-js": "2.5.4",
         "@microsoft/applicationinsights-channel-js": "2.5.4",
         "@microsoft/applicationinsights-common": "2.5.4",
         "@microsoft/applicationinsights-core-js": "2.5.4",
         "@microsoft/applicationinsights-dependencies-js": "2.5.4",
-        "@microsoft/applicationinsights-properties-js": "2.5.4",
-        "tslib": "1.11.2"
+        "@microsoft/applicationinsights-properties-js": "2.5.4"
     },
     "license": "MIT"
 }
diff --git a/AISKU/src/applicationinsights-web.ts b/AISKU/src/applicationinsights-web.ts
@@ -1,3 +1,5 @@
+import '@microsoft/applicationinsights-shims';
+
 export {
     IApplicationInsights,
     Snippet,

diff --git a/AISKU/tsconfig.json b/AISKU/tsconfig.json
@@ -9,7 +9,7 @@
     "alwaysStrict": true,
     "suppressImplicitAnyIndexErrors": true,
     "allowSyntheticDefaultImports": true,
-    "importHelpers": true,
+    "importHelpers": false,
     "noEmitHelpers": true,
     "forceConsistentCasingInFileNames": true,
     "declaration": true,

diff --git a/AISKULight/index.ts b/AISKULight/index.ts
@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+import '@microsoft/applicationinsights-shims';
 import {
     IConfiguration,
     AppInsightsCore,

diff --git a/AISKULight/package.json b/AISKULight/package.json
@@ -28,12 +28,12 @@
     },
     "dependencies": {
         "@microsoft/dynamicproto-js": "^0.5.2",
+        "@microsoft/applicationinsights-shims" : "1.0.0",
         "@microsoft/applicationinsights-common": "2.5.4",
         "@microsoft/applicationinsights-channel-js": "2.5.4",
         "@microsoft/applicationinsights-core-js": "2.5.4"
     },
     "peerDependencies": {
-        "tslib": "1.11.2"
     },
     "license": "MIT"
 }
diff --git a/AISKULight/tsconfig.json b/AISKULight/tsconfig.json
@@ -9,7 +9,7 @@
     "alwaysStrict": true,
     "suppressImplicitAnyIndexErrors": true,
     "allowSyntheticDefaultImports": true,
-    "importHelpers": true,
+    "importHelpers": false,
     "noEmitHelpers": true,
     "forceConsistentCasingInFileNames": true,
     "declaration": true,