Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for withAITracking wrapping functional components. #1275

Merged
merged 4 commits into from May 29, 2020

Conversation

Ishraque99
Copy link
Contributor

fix for issues #1274 and #1117

Can also use empty string instead of 'Anonymous component'. Let me know which is preferred.

@Ishraque99 Ishraque99 requested a review from a team as a code owner May 28, 2020 14:14
componentName = Component.prototype &&
Component.prototype.constructor &&
Component.prototype.constructor.name ||
'Anonymous component';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with with either just "Anonymous" or perhaps "Unknown"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like "Unknown". Updated.

@markwolff markwolff merged commit 1f45259 into microsoft:master May 29, 2020
@MSNev MSNev added this to the 2.5.5 milestone Jun 2, 2020
@MSNev MSNev linked an issue Jun 2, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] WithAITracking cannot wrap around functional components
3 participants