Remove exposing global instances of __extends() and __assign() and update sideEffects usage (by removing globals) #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Apr 2, 2021
MSNev
commented
- [BUG] Investigate changing the sideEffects: false to list only the files that include the shims module from the all AI modules so that webpack can evaluate correctly [BUG] Investigate changing the sideEffects: false to list only the files that include the shims module from the all AI modules so that webpack can evaluate correctly #1509
- Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims Investigate removing the globals __extends() and __assign() populated by applicationinsights-shims #1280
MSNev
requested review from
trask,
ramthi,
lzchen,
xiao-lix,
hectorhdzg,
heyams and
kryalama
MSNev
commented
Apr 2, 2021
| }, | ||
| "dependencies": { | ||
| "@microsoft/applicationinsights-common": "^2.6.0", | ||
| "@microsoft/applicationinsights-core-js": "^2.6.0", | ||
| "@microsoft/applicationinsights-shims": "^1.0.3", | ||
| "@microsoft/applicationinsights-shims": "^2.0.0", |
There was a problem hiding this comment.
This will keep failing until we publish the updated shims -- removing for now
MSNev
force-pushed
the
MSNev/Shims
branch
2 times, most recently
from
1ad1cf4
to
f18eb30
Compare
kryalama
approved these changes
Apr 14, 2021
hectorhdzg
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.