[Main][Task]27939476: Initialization with iKey and endpoint to be promises #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karlie-777
commented
May 2, 2024
| let ikey = _config.instrumentationKey; | ||
| if (!res.rejected && curCs) { | ||
| // replace cs with resolved values in case of circular promises | ||
| _config.connectionString = curCs; |
There was a problem hiding this comment.
need to set connection string to be string to avoid future promise calls
Karlie-777
commented
May 2, 2024
| @@ -268,6 +270,12 @@ export class Sender extends BaseTelemetryPlugin implements IChannelControls { | |||
| } | |||
| }); | |||
|
|
|||
| if (core.activeStatus() === ActiveStatus.PENDING) { | |||
| // waiting for core promises to be resolved | |||
| return; | |||
There was a problem hiding this comment.
if core active status is pending, do nothing
Karlie-777
commented
May 2, 2024
|
|
||
| if (isNullOrUndefined(ikey)) { | ||
| _activeStatus = ActiveStatus.INACTIVE; | ||
| if (!_isInitialized) { |
There was a problem hiding this comment.
only throw error during first initialization, not during config changes
Karlie-777
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.