Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling instrumentation of logging no longer works #2590

Closed
dvag-holger-krusemark opened this issue Oct 12, 2022 · 1 comment · Fixed by #2592
Closed

Disabling instrumentation of logging no longer works #2590

dvag-holger-krusemark opened this issue Oct 12, 2022 · 1 comment · Fixed by #2592
Assignees

Comments

@dvag-holger-krusemark
Copy link

We disabled instrumentation of logging (log4j2) by
export APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVEL=OFF
Disabling worked in version 3.2.4. After upgrading to version 3.3.0, disabling no longer works and the agent transfers all (severity level from 0 to 3) log messages to azure.
The agent in version 3.4.1 behaves the same way.

Expected behavior

Log messages are not transmitted to azure, when environment variable
APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVEL is set to "OFF".
If the value is set to "FATAL", the agent only transmits log messages with serverity level 4 (FATAL).

Actual behavior

When starting the application, the agent logs the message
DEBUG c.m.a.a.i.c.ConfigurationBuilder - read environment variable: APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVEL=OFF
All log messages (log severity from 0 to at least 3) are transmitted to azure.
If the value is set to "FATAL", the agent transmits log messages with serverity level 3 (ERROR).

To Reproduce

Sample Application

System information

Please provide the following information:

  • SDK Version: 3.3.0, 3.4.1
  • OS type and version: Linux
  • Application Server type and version (if applicable): Tomcat
  • Using spring-boot? No
  • Additional relevant libraries (with version, if applicable): log4j-2-17.0

Logs

Screenshots

@ghost ghost added the Needs: Triage 🔍 label Oct 12, 2022
@trask trask self-assigned this Oct 12, 2022
@trask
Copy link
Member

trask commented Oct 13, 2022

@dvag-holger-krusemark thanks for reporting this! it should be fixed by #2592, and will be included in our next release which we are targeting for mid to end of next week.

trask added a commit that referenced this issue Oct 18, 2022
@ghost ghost added the Status: Fixed label Oct 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants