Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OFF logging threshold #2592

Merged
merged 1 commit into from Oct 18, 2022
Merged

Fix OFF logging threshold #2592

merged 1 commit into from Oct 18, 2022

Conversation

trask
Copy link
Member

@trask trask commented Oct 13, 2022

Resolves #2590

}

public static Severity getSeverity(String level) {
public static int getSeverityThreshold(String level) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(suggestion) This method might be moved in AgentLogExporter and called around line 84. So all the log logic would be in the place where we need it. A boolean exportLog(LogData log, String configuredLogThreshold) method might then be added and contains all the log level logic for the export. The configuration object would then represent the log level as a string an not an int.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks a bit more challenging, as we are also using this method for fail-fast validation of the configuration:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling instrumentation of logging no longer works
3 participants