Option to export logback code attributes #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The metrics are those used on the .net side. |
jeanbisutti
commented
Sep 14, 2022
...ngAgent/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/TraceLogBackTest.java
Outdated
Show resolved
Hide resolved
|
Doc could be new section right above https://docs.microsoft.com/en-us/azure/azure-monitor/app/java-standalone-config#logginglevel |
trask
reviewed
Sep 15, 2022
| @@ -216,6 +216,7 @@ public static class JdbcMasking { | |||
|
|
|||
| public static class LoggingInstrumentation { | |||
| public String level = "INFO"; | |||
| public boolean captureCodeAttributes; | |||
There was a problem hiding this comment.
it may be good to put it under logback-specific preview configuration, until we support across all logging instrumentations, e.g.
{
"preview": {
"captureLogbackCodeAttributes": true
}
}
jeanbisutti
force-pushed
the
2477-logging
branch
from
d5ce9a5
to
9a5c323
Compare
Done |
|
I changed the base branch for this PR to the 1.18.0 PR temporarily to make it easier to review |
trask
force-pushed
the
update-to-otel-1.18.0
branch
from
6b4389b
to
8038293
Compare
…nstrumentation release
trask
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the implementation of #2477.
The OTel code attributes will be available for Logback in the next
otel-java-instrumentationrelease.This PR aims at exporting the related metrics.