Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure SDK target mapping #2787

Merged
merged 2 commits into from Dec 13, 2022
Merged

Fix Azure SDK target mapping #2787

merged 2 commits into from Dec 13, 2022

Conversation

trask
Copy link
Member

@trask trask commented Dec 11, 2022 •
edited

See #2699

@trask trask marked this pull request as ready for review December 11, 2022 21:48
@trask trask mentioned this pull request Dec 11, 2022
Closed
jeanbisutti
jeanbisutti reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@jeanbisutti jeanbisutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether all the substring calls are reasonable in terms of performance.

...r/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/utils/UrlParser.java Outdated Show resolved Hide resolved
...st/java/com/azure/monitor/opentelemetry/exporter/implementation/utils/UrlParserPathTest.java Show resolved Hide resolved
.../java/com/azure/monitor/opentelemetry/exporter/implementation/utils/UrlParserTargetTest.java Show resolved Hide resolved
@trask trask merged commit 3aa7d31 into main Dec 13, 2022
@trask trask deleted the fix-azure-sdk-target branch December 13, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@heyams heyams Awaiting requested review from heyams heyams is a code owner

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trask @jeanbisutti