JMX Metrics to OTLP & Breeze #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of 2 - seems like timing issue
…r metric when defaults not in json
harsimar
requested review from
heyams,
jeanbisutti,
ramthi and
trask
as code owners
trask
reviewed
Nov 30, 2023
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Outdated
Show resolved
Hide resolved
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Nov 30, 2023
...ava/com/microsoft/applicationinsights/agent/internal/init/PerformanceCounterInitializer.java
Outdated
Show resolved
Hide resolved
heyams
reviewed
Nov 30, 2023
...ava/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Outdated
Show resolved
Hide resolved
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Outdated
Show resolved
Hide resolved
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Nov 30, 2023
...ava/com/microsoft/applicationinsights/agent/internal/init/PerformanceCounterInitializer.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Dec 1, 2023
...ava/com/microsoft/applicationinsights/agent/internal/init/PerformanceCounterInitializer.java
Outdated
Show resolved
Hide resolved
…ar/ApplicationInsights-Java into harskaur/jmkMetricsToOtlp
jeanbisutti
approved these changes
Dec 20, 2023
…ar/ApplicationInsights-Java into harskaur/jmkMetricsToOtlp
trask
reviewed
Jan 9, 2024
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 10, 2024
Comment on lines
118
to
122
| } catch (RuntimeException e) { | ||
| try (MDC.MDCCloseable ignored = CUSTOM_JMX_METRIC_ERROR.makeActive()) { | ||
| logger.error("Failed to register JMX performance counters: '{}'", e.toString()); | ||
| } | ||
| } |
There was a problem hiding this comment.
it looks like previously we had try/catch around each JMX metric, which could be better since then a single JMX metric problem wouldn't affect the others
There was a problem hiding this comment.
there is another try block above.
trask
reviewed
Jan 10, 2024
...ava/com/microsoft/applicationinsights/agent/internal/init/PerformanceCounterInitializer.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 10, 2024
...keTest/java/com/microsoft/applicationinsights/smoketest/DetectUnexpectedOtelMetricsTest.java
Show resolved
Hide resolved
trask
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes for customers to collect JMX metrics via OTLP and application insights. It expects that the customer sets the environment variable or system property for the otel metrics exporter to use OTLP when launching their own application. However, application insights will set the
otel.metric.export.intervalto matchmetricIntervalSecondsfrom applicationinsights.json. An example launch of the spring pet clinic sample app below:java -javaagent:"<path to app insights java agent>" -Dotel.metrics.exporter=otlp -jar target\spring-petclinic-3.1.0-SNAPSHOT.jarA customer could then set up an OTLP collector/endpoint to receive metrics.
A few notes about behavior:
observableDoubleMeasurementthat gets observed once for export to Breeze and another time for the OTLP collector. This behavior may be revisited in a future sprint./characters open-telemetry/opentelemetry-specification#3422 (comment)). I am working on a separate PR to make sure that the jmx metric still reports to Breeze the original spaces: Using the jmx metric attribute as the metric name for JMX metrics Azure/azure-sdk-for-java#37880Test coverage: