Fix ingestion sampling #3578
Merged
Fix ingestion sampling #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Mar 6, 2024
.../main/java/com/microsoft/applicationinsights/agent/internal/configuration/Configuration.java
Show resolved
Hide resolved
trask
commented
Mar 6, 2024
...ava/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationBuilder.java
Show resolved
Hide resolved
heyams
reviewed
Mar 6, 2024
.../main/java/com/microsoft/applicationinsights/agent/internal/configuration/Configuration.java
Show resolved
Hide resolved
...ava/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationBuilder.java
Show resolved
Hide resolved
.../main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingPercentage.java
Outdated
Show resolved
Hide resolved
.../main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingPercentage.java
Show resolved
Hide resolved
|
can we test Azure/azure-sdk-for-java#39103 in this PR? i didn't find azure-sdk snapshot. |
trask
force-pushed
the
ingestion-sampling
branch
from
d651bc7
to
4a417bc
Compare
trask
force-pushed
the
ingestion-sampling
branch
from
7553bdb
to
e6371ae
Compare
heyams
reviewed
Mar 7, 2024
trask
force-pushed
the
ingestion-sampling
branch
3 times, most recently
from
87d1f94
to
5f9be92
Compare
heyams
force-pushed
the
ingestion-sampling
branch
from
5f9be92
to
b758984
Compare
heyams
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Azure/azure-sdk-for-java#39103
TODO add smoke test