Don't emit Current Thread Count and Loaded Class Count to OTLP #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsimar
requested review from
heyams,
jeanbisutti,
ramthi and
trask
as code owners
heyams
reviewed
May 2, 2024
...keTest/java/com/microsoft/applicationinsights/smoketest/DetectUnexpectedOtelMetricsTest.java
Outdated
Show resolved
Hide resolved
heyams
reviewed
May 9, 2024
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Outdated
Show resolved
Hide resolved
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Show resolved
Hide resolved
heyams
reviewed
May 9, 2024
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Helen <56097766+heyams@users.noreply.github.com>
|
@harsimar beta.22 standalone exporter is live. please update your PR to run smoke tests with it. |
heyams
reviewed
May 14, 2024
| * the OTEL collector will still get the metric names with _. When that change gets merged & | ||
| * incorporated, we will need to change this/DetectUnexpectedOtelMetrics test so that the Breeze | ||
| * verification expects our default jmx metrics with spaces. | ||
| * <p>- Loaded Class Count: This covers the case of collecting a default jmx metric that the |
There was a problem hiding this comment.
can we mention this metric goes to breeze only now?
trask
approved these changes
May 15, 2024
Comment on lines
124
to
127
| System.out.println("Printing metrics names to # of occurrences for otlp"); | ||
| for (Map.Entry<String, Integer> entry : occurrences.entrySet()) { | ||
| System.out.println(entry.toString()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| System.out.println("Printing metrics names to # of occurrences for otlp"); | |
| for (Map.Entry<String, Integer> entry : occurrences.entrySet()) { | |
| System.out.println(entry.toString()); | |
| } |
.../JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java
Show resolved
Hide resolved
harsimar
changed the title
jeanbisutti
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a couple metrics (Current Thread Count & Loaded Class Count) flowing to OTLP & Breeze. Since these two metrics also have analogous metrics in the otel runtime instrumentation, and they aren't custom JMX metrics, removed these two metrics from the OTLP code path (it just goes to Breeze to maintain backwards compatibility until v4).