Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Custom Exporters #288

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jeremydvoss
Copy link
Member

Based off how auto instrumentation uses the exporter environment variables, I enabled the distro to use the entry points for additional exporters.

@jeremydvoss jeremydvoss marked this pull request as ready for review May 31, 2023 23:05
@jeremydvoss jeremydvoss requested review from a team and lzchen as code owners May 31, 2023 23:05
@lzchen
Copy link
Contributor

lzchen commented Jun 1, 2023

What's the purpose of this feature? Why do we allow users to use other exporters besides azure monitor?

@jeremydvoss
Copy link
Member Author

What's the purpose of this feature? Why do we allow users to use other exporters besides azure monitor?

With our emphasis on using env vars for configuring the distro, it seemed to make sense to use the exporter env vars like how they are used in the auto instrumentation flow. Users may want to export to multiple places or output to the console.

Granted, it is possible to add trace and log exporters after the fact. But this approach would be needed for allowing additional periodic metric readers and seems much more user friendly for the tracing and log cases as well.

Since it is not strictly necessary, we can hold off, but is there a deeper reason for the hesitance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants