only createt qps client when enabled (#613)

microsoft · Apr 9, 2020 · 156036c · 156036c
1 parent a34f9e2
commit 156036c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/Tests/applicationInsights.tests.ts b/Tests/applicationInsights.tests.ts
@@ -85,6 +85,11 @@ describe("ApplicationInsights", () => {
             AppInsights.setup("key").start();
             assert.equal(AppInsights.liveMetricsClient, undefined, "live metrics client is not defined");
         });
+
+        it("should not start live metrics", () => {
+            AppInsights.setup("key").setSendLiveMetrics(false).start();
+            assert.equal(AppInsights.liveMetricsClient, undefined, "live metrics client is not defined");
+        });
     });
 
     describe("#setDistributedTracingMode", () => {

diff --git a/applicationinsights.ts b/applicationinsights.ts
@@ -311,13 +311,13 @@ export class Configuration {
             return Configuration;
         }
 
-        if (!liveMetricsClient) {
+        if (!liveMetricsClient && enable) {
             // No qps client exists. Create one and prepare it to be enabled at .start()
             liveMetricsClient = new QuickPulseClient(defaultClient.config.instrumentationKey);
             _performanceLiveMetrics = new AutoCollectPerformance(liveMetricsClient as any, 1000, true);
             liveMetricsClient.addCollector(_performanceLiveMetrics);
             defaultClient.quickPulseClient = liveMetricsClient; // Need this so we can forward all manual tracks to live metrics via PerformanceMetricsTelemetryProcessor
-        } else {
+        } else if (liveMetricsClient) {
             // qps client already exists; enable/disable it
             liveMetricsClient.enable(enable);
         }