fix bad requests causing unit tests to hang (#478)

* fix hanging requests

* change mocha to 3.5.2

* add --no-exit tag to unit tests

* unref diskretry timeout to prevent blocking app from terminating

Library/Sender.ts

@@ -135,7 +135,7 @@ class Sender {
                     if (this._enableDiskRetryMode) {
                         // try to send any cached events if the user is back online
                         if (res.statusCode === 200) {
-                            setTimeout(() => this._sendFirstFileOnDisk(), this._resendInterval);
+                            setTimeout(() => this._sendFirstFileOnDisk(), this._resendInterval).unref();
                             // store to disk in case of burst throttling
                         } else if (
                             res.statusCode === 408 || // Timeout

Tests/EndToEnd.tests.ts

@@ -18,7 +18,7 @@ import { CorrelationContextManager } from "../AutoCollection/CorrelationContextM
 class fakeResponse {
     private callbacks: { [event: string]: (data?: any) => void } = Object.create(null);
     public setEncoding(): void { };
-    public statusCode: number;
+    public statusCode: number = 200;
 
     constructor(private passImmediately: boolean = true) { }
 

Tests/Library/Config.tests.ts

@@ -1,5 +1,7 @@
 import assert = require("assert");
 import sinon = require("sinon");
+var http = require("http");
+var https = require("https");
 
 import Config = require("../../Library/Config");
 
@@ -9,6 +11,14 @@ describe("Library/Config", () => {
     var appVer = "appVer";
 
     describe("#constructor(iKey)", () => {
+        beforeEach(()=> {
+            sinon.stub(http, 'request');
+            sinon.stub(https, 'request');
+        });
+        afterEach(() => {
+            http.request.restore();
+            https.request.restore();
+        })
         it("should throw if no iKey is available", () => {
             var env = {};
             var originalEnv = process.env;

Tests/Library/Util.tests.ts

@@ -304,8 +304,8 @@ describe("Library/Util", () => {
                 if (process.env.hasOwnProperty('no_proxy')) {
                     delete process.env.no_proxy;
                 }
-                sinon.spy(http, 'request');
-                sinon.spy(https, 'request');
+                sinon.stub(http, 'request');
+                sinon.stub(https, 'request');
             });
 
             afterEach(() => {

package.json

@@ -42,18 +42,18 @@
     "prepublishOnly": "npm run build",
     "pretest": "npm run build",
     "test": "npm run test:ts && npm run test:js",
-    "test:ts": "mocha ./out/Tests --recursive",
-    "test:js": "mocha ./Tests/js --recursive",
+    "test:ts": "mocha ./out/Tests --recursive --no-exit",
+    "test:js": "mocha ./Tests/js --recursive --no-exit",
     "functionaltest": "npm run build && npm pack && node --use_strict ./Tests/FunctionalTests/RunFunctionalTests.js",
     "backcompattest": "npm run build && npm pack && node --use_strict ./Tests/BackCompatibility/RunBackCompatTests.js"
   },
   "devDependencies": {
     "@types/cls-hooked": "^4.2.1",
-    "@types/mocha": "2.2.40",
+    "@types/mocha": "2.2.48",
     "@types/node": "4.2.4",
     "@types/sinon": "2.1.2",
     "typescript": "2.4.2",
-    "mocha": "3.1.2",
+    "mocha": "3.5.2",
     "node-mocks-http": "1.2.3",
     "sinon": "1.17.6"
   },