Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Default Logger Settings and Add Console Log Level Support #1326

Merged
merged 3 commits into from May 10, 2024
Merged

Fix Default Logger Settings and Add Console Log Level Support #1326

merged 3 commits into from May 10, 2024

Conversation

JacksonWeber
Copy link
Contributor

@JacksonWeber JacksonWeber commented May 10, 2024 •
edited

Updated defaults such that:

  • Winston & bunyan are on by default in general
  • Console log collection is off by default
  • Console log collection is on by default in AKS attach scenario

Also added support for Console logging log level.

hectorhdzg
hectorhdzg approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonWeber JacksonWeber merged commit cbd15ec into microsoft:main May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JacksonWeber @hectorhdzg