Tighten TODO check to all directories (#6177)

microsoft · May 17, 2024 · 8cc1c42 · 8cc1c42
1 parent b3d0eff
commit 8cc1c42
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/scripts/check-todo.sh b/scripts/check-todo.sh
@@ -13,7 +13,7 @@ DENYLIST="TODO FIXME"
 STATUS=0
 
 for DENYTERM in $DENYLIST; do
-  FOUND=$(git ls-files "$@" | xargs grep -n "$DENYTERM")
+  FOUND=$(git ls-files ":!:3rdparty" ":!:.github/ISSUE_TEMPLATE" ":!:scripts/ci-checks.sh" ":!:scripts/check-todo.sh" ":!:Doxyfile" "$@" | xargs grep -n "$DENYTERM")
 
   if [ "$FOUND" == "" ]; then
     echo "No ${DENYTERM}s found"

diff --git a/scripts/ci-checks.sh b/scripts/ci-checks.sh
@@ -36,8 +36,9 @@ group "Shell scripts"
 git ls-files | grep -e '\.sh$' | grep -E -v "^3rdparty" | xargs shellcheck -s bash -e SC2044,SC2002,SC1091,SC2181
 endgroup
 
+# No inline TODOs in the codebase, use tickets, with a pointer to the code if necessary.
 group "TODOs"
-"$SCRIPT_DIR"/check-todo.sh include src
+"$SCRIPT_DIR"/check-todo.sh .
 endgroup
 
 group "Public includes"