-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup js::core::Context
, move functionality to ExtensionInterface
s
#6163
Merged
achamayou
merged 35 commits into
microsoft:main
from
eddyashton:js_interp_publicisation_ii
May 17, 2024
Merged
Cleanup js::core::Context
, move functionality to ExtensionInterface
s
#6163
achamayou
merged 35 commits into
microsoft:main
from
eddyashton:js_interp_publicisation_ii
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO before merging:
|
achamayou
reviewed
May 17, 2024
achamayou
approved these changes
May 17, 2024
eddyashton
changed the title
[WIP] Cleanup
Cleanup May 17, 2024
js::core::Context
, move to an extension modeljs::core::Context
, move functionality to ExtensionInterface
s
…F into js_interp_publicisation_ii
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is for
js::core::Context
to be a pure interpreter (ie - we don't insert anything that QuickJS doesn't), and a vaguely readable interface. This PR works towards the latter by shuffling methods around, removing a few unused/unnecessary overloads, and the former by introducing anExtension
pattern rather thanpopulate_global_XXX
methods on theContext
.A goal of this extension pattern is the removal of the messy
globals
object onContext
- previously lots of inserted calls relied on theglobals.tx
object inserted to support theccf.kv
functions. Now they explicitly use the state in their own extension, including aTx*
where necessary. This should also simplify cleanup, as its a case of deleting extensions rather than invalidating global values.