Converted no-relative-import-in-test from TSLint to ESLint #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the title
|
I'm going to try to get this up-to-date and matched with a DT fixup today. |
|
lodash is the only package with an exclusion for this rule. I'm going to merge this and ship it, but I need to figure out how to test locally reliably. It may be that dt-tools needs to update to the same version of typescript that DT uses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. I can't figure out how to get the types to work in test.Strange, I'd been under the impression they were failing at some point. But it seems like they're working. ✅Continues #648 by migrating
no-relative-import-in-testfrom TSLint to ESLint.