Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted strict-export-declare-modifiers from TSLint to ESLint, ish #680

Merged
merged 4 commits into from Sep 22, 2023
Merged

Converted strict-export-declare-modifiers from TSLint to ESLint, ish #680

merged 4 commits into from Sep 22, 2023

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented May 21, 2023 •
edited

Continues #648 by migrating strict-export-declare-modifiers from TSLint to ESLint...

...mostly. This removes the dependency on tslint but still operates on the TS tree instead of TSESTree tree. I ran out of energy overhauling these more TypeScript-intertwined rules... is this ok as an intermediary step?

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 21, 2023 11:23
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 21, 2023
Closed
@sandersn sandersn mentioned this pull request Sep 22, 2023
Merged
sandersn
sandersn approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to leave the TS-centric code for now. I don't believe we've had trouble with the tslint rule unlike some others that have broken with TS API changes over the years.

@sandersn sandersn merged commit 08cc565 into microsoft:master Sep 22, 2023
5 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the strict-export-declare-modifiers branch September 22, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey left review comments

@sandersn sandersn sandersn approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshuaKGoldberg @sandersn @jakebailey