Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove formatting rules rules from dtslint #699

Merged

Conversation

JoshuaKGoldberg
Copy link
Contributor

Targets a bit of both of:

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 31, 2023 21:36
@@ -14,33 +13,12 @@

"comment-format": [true, "check-space"], // But not check-uppercase or check-lowercase
"interface-name": [true, "never-prefix"],
"max-line-length": [true, 200],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda funky that we have 200 here but 120 in the prettier config (and now dprint config). Of course, I personally use 120 so 🤫

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this shortly before the first dprint PR on DT goes in.

@@ -1,86 +0,0 @@
import * as Lint from "tslint";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha, so that's what the other dtslint rules were doing!

@sandersn sandersn merged commit b779af5 into microsoft:master Aug 29, 2023
6 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the dtslint-remove-formatting-rules branch August 29, 2023 16:24
@mastrzyz
Copy link
Contributor

@JoshuaKGoldberg if I understand correctly, this should be a follow-up PR DefinitelyTyped/DefinitelyTyped#66514 right?

@JoshuaKGoldberg
Copy link
Contributor Author

Aha, yes, I'd started on a followup PR to DT that removes all of these no-longer-present rules. no-padding, max-line-length, etc. will all need to be removed. https://github.com/DefinitelyTyped/DefinitelyTyped/blob/5a9a8169b876794ba85780d7822a287bf0545107/scripts/tslint-rule-to-eslint.js should be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants