New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(shared-tree): Add simple LazyOptionalField unit tests #17475
Merged
noencke
merged 41 commits into
microsoft:main
from
Josmithr:shared-tree/lazy-field-tests
Sep 28, 2023
Merged
test(shared-tree): Add simple LazyOptionalField unit tests #17475
noencke
merged 41 commits into
microsoft:main
from
Josmithr:shared-tree/lazy-field-tests
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
Issues related to distributed data structures
area: dds: tree
base: main
PRs targeted against main branch
labels
Sep 26, 2023
Josmithr
commented
Sep 26, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/editableTreeTypes.ts
Outdated
Show resolved
Hide resolved
Josmithr
commented
Sep 26, 2023
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/lazyField.spec.ts
Outdated
Show resolved
Hide resolved
Josmithr
commented
Sep 26, 2023
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/lazyField.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/lazyField.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/lazyField.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/lazyField.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/lazyField.spec.ts
Outdated
Show resolved
Hide resolved
noencke
approved these changes
Sep 27, 2023
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/lazyField.spec.ts
Outdated
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/lazyField.spec.ts
Show resolved
Hide resolved
noencke
approved these changes
Sep 27, 2023
Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
/azp run Build - client packages |
Azure Pipelines successfully started running 1 pipeline(s). |
DLehenbauer
pushed a commit
that referenced
this pull request
Sep 29, 2023
This PR implements sequence mutation methods. Tests will be added in a follow-up PR when #17475 is complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
base: main
PRs targeted against main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an intro suite of unit tests for
LazyOptionalField
. Specifically, adds tests for the following properties and methods:is
length
map
mapBoxed