build(dds): Fix type generation for ESM and add exports field #18823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
github-actions
bot
added
the
dependencies
⯅ @fluid-example/bundle-size-tests: +18 Bytes
Baseline commit: 7a248ae |
tylerbutler
changed the title
This was referenced Dec 14, 2023
Josmithr
reviewed
Dec 14, 2023
Josmithr
reviewed
Dec 14, 2023
fluidBuild.config.cjs
Outdated
| @@ -159,9 +167,17 @@ module.exports = { | |||
| // Can be removed once the policy handler is updated to support tsc-multi as equivalent to tsc. | |||
There was a problem hiding this comment.
Nit: might be worth noting the work item number tracking this cleanup for reference.
Josmithr
reviewed
Dec 14, 2023
Josmithr
approved these changes
Dec 14, 2023
tylerbutler
added a commit
that referenced
this pull request
Dec 14, 2023
…ts field (#18825) This PR updates sequence and merge-tree to generate proper types in ESM builds and adds an exports field. I had to update the test files a bit to clean up imports. I also added a ./dist/test export from merge-tree since its internals are used by sequence tests. This is a demonstration of the mechanism we will have to use any time we want to export something for use in another package. No more reaching into internals! This PR includes some configuration and settings changes that are not strictly needed for this PR, but splitting them out doesn't seem worth the time since they're all needed for other pending PRs like #18823 and #18824.
github-actions
bot
removed
area: build
tyler-cai-microsoft
pushed a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Jan 10, 2024
…ts field (microsoft#18825) This PR updates sequence and merge-tree to generate proper types in ESM builds and adds an exports field. I had to update the test files a bit to clean up imports. I also added a ./dist/test export from merge-tree since its internals are used by sequence tests. This is a demonstration of the mechanism we will have to use any time we want to export something for use in another package. No more reaching into internals! This PR includes some configuration and settings changes that are not strictly needed for this PR, but splitting them out doesn't seem worth the time since they're all needed for other pending PRs like microsoft#18823 and microsoft#18824.
tyler-cai-microsoft
pushed a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Jan 10, 2024
…ts field (microsoft#18825) This PR updates sequence and merge-tree to generate proper types in ESM builds and adds an exports field. I had to update the test files a bit to clean up imports. I also added a ./dist/test export from merge-tree since its internals are used by sequence tests. This is a demonstration of the mechanism we will have to use any time we want to export something for use in another package. No more reaching into internals! This PR includes some configuration and settings changes that are not strictly needed for this PR, but splitting them out doesn't seem worth the time since they're all needed for other pending PRs like microsoft#18823 and
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the majority of packages in /dds (merge-tree and sequence excluded) to generate proper types in ESM builds and adds an
exportsfield. The packages were already building using moduleResolution: node16 by virtue of inheriting from the new shared configs, so no changes were needed there. They also have a test using arethetypeswrong that runs in CI.