Wait for container connection in service load test #21079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
| @@ -256,6 +256,7 @@ async function runnerProcess( | |||
| container = await loader.resolve({ url, headers }, stashedOps); | |||
|
|
|||
| container.connect(); | |||
| await waitForContainerConnectionWithTimeout(container); | |||
There was a problem hiding this comment.
something like this already happens within the below test.run(runConfig, reset). if something is missed there, that would be a better place for it.
also, should we consider not logging op round trip perf when not connected? as this is a real scenario, and i don't think we would want to log errors when it happens in any case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tinylicious is seeing lots of
"OpRoundtripTime"errors around the time of initialization. We should wait until we connect to start sending the ops.AB#7819