fix(build-tools): fluid-build-tasks-eslint deps #21089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getDefaultTscTaskDependencies was ineffective and is now removed. eslint with ts processing does not require build first. Instead of requiring that tsc is run for the projects listed in lint config, depend on the things the respective tsc tasks depend on. Once policy changes are picked up by client group ^tsc dependencies listed for eslint in examples/data-objects can be removed.
github-actions
bot
added
area: build
Josmithr
reviewed
May 15, 2024
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
May 15, 2024
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
May 15, 2024
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
May 15, 2024
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Show resolved
Hide resolved
Josmithr
approved these changes
May 15, 2024
alexvy86
reviewed
May 15, 2024
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
build-tools/packages/build-cli/src/library/repoPolicyCheck/fluidBuildTasks.ts
Outdated
Show resolved
Hide resolved
alexvy86
approved these changes
May 16, 2024
kekachmar
pushed a commit
to kekachmar/FluidFramework
that referenced
this pull request
May 21, 2024
getDefaultTscTaskDependencies was ineffective and is now removed. eslint with ts processing does not require build first. Instead of requiring that tsc is run for the projects listed in lint config, depend on the things the respective tsc tasks depend on. Once policy changes are picked up by client group ^tsc dependencies listed for eslint in examples/data-objects can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDefaultTscTaskDependencies was ineffective and is now removed. eslint with ts processing does not require build first. Instead of requiring that tsc is run for the projects listed in lint config, depend on the things the respective tsc tasks depend on.
Once policy changes are picked up by client group ^tsc dependencies listed for eslint in examples/data-objects can be removed.