Enable checkstyle && fix issues in entity/agent #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydraxman
reviewed
Mar 15, 2023
| @@ -33,8 +34,12 @@ public MobileDevice() { | |||
|
|
|||
| @Override | |||
| public boolean equals(Object o) { | |||
| if (this == o) return true; | |||
There was a problem hiding this comment.
Could we consider allowing this style and disabling this rule entirely? I this the oneliner is quite useful and readable.
There was a problem hiding this comment.
We can remove NeedBraces in our checkstyle-ruleset.xml, but I personally don't like non-braces style xD
|
Could you modify the doc contributing guide and provide a list there to list all the enabled rules? Or if there are too many, you may briefly summarise the goal or the recommended coding practices of this change in the doc, and attach some official doc link of checkstyle in the contributing doc to provide clarity. @TedaLIEz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this introduce a breaking change?
If this introduces a breaking change for Hydra Lab users and requires a migration process, please describe the impact and migration path for existing applications below.
Pull Request Description
Enable checkstyle in common module, wave 1
Please check the type of change your PR introduces:
A few words to explain your changes:
Does this close any currently open issues? Issue ID: #
How you tested it
Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
Feature UI Screenshots or Technical Design Diagrams
If this is a relatively large or complex change, kick off the discussion by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...