Set default SlnGenProjectName for Traversal projects #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open to thoughts / considerations on the benefits / risks here, but wanted to open a PR to start the conversation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/slngen#557 added support for customizing the solution name using the MSBuild property
<SlnGenProjectName>.Today, if a user runs SlnGen with default properties, every VS window will unhelpfully be named "dirs". With this change, if a user hasn't set this property, this change sets it to the parent directory name, which is usually more descriptive. In some cases that may result in equally unhelpful names like "src", but that's no worse than today.
This may be considered a breaking change for SlnGen users in some scenarios. Specifically, if they were running slngen with no parameters set and then assuming the resulting solution would be named
{dirs}.sln. In many cases, anyone that's writing scripts with slngen is also setting-o|--solutionfile, so they wouldn't be impacted, but I'm sure someone is relying on the name.