Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KBM] Convert RemapBufferRow to a struct with descriptive field names #32545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

masaru-iritani
Copy link
Contributor

Summary of the Pull Request

This refactoring pull request changes RemapBufferRow from std::pair to a struct.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Using std::pair has two problems.

Converting the type to a struct with more descriptive field names will make it easier to understand and extend (for #5679).

Validation Steps Performed

  • All unit tests pass locally.
  • Keyboard Manager Settings can show existing key remaps and shortcut remaps.

@masaru-iritani masaru-iritani changed the title Convert RemapBufferRow to a struct with descriptive field names [KBM] Convert RemapBufferRow to a struct with descriptive field names Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant