Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPS] Update Unitsnet to 5.50.0 #32572

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Jvr2022
Copy link

@Jvr2022 Jvr2022 commented Apr 22, 2024

changes

  • Add operators for ReciprocalLength/-Area
  • Change nuget license from MIT to MIT-0
  • Add operator to convert from TemperatureDelta to TemperatureChangeRate.
  • Add MagenticField and Acceleration for .NET nanoFramework
  • Change DataMember ordering to 1-indexed
  • Add VolumeFlow prefixes Deca
  • Add Btu/ft² in irradiation
  • Add radiation equivalent dose
  • Fix precision of Volume.CubicInch
  • Add radiation exposure
  • Add radioactivity
  • Add units for Molality
  • Add Kilo prefix to yards
  • Improve precision of PR 1334
  • Add density unit PoundsPerCubicYard + Kilo prefix
  • Bump nanoFramework refs
  • ci: 🔧Update pipelines for v4
  • Added some nullability annotations to v4
  • Add Femto prefixes to density
  • Add micro and nano prefixes
  • Added Gigameter (1e+9 meters)
  • Fix force conversion rates
  • Set neutral language to en-US
  • Fix concurrency issue getting abbreviations
  • EADME: Update information referring to QuantityType removed in v5
  • Fix unit abbreviation lookup for unit value cast to Enum
  • Add Pico and Femto prefixes to meter
  • Fix stack overflow deserializing empty JSON
  • Add CoefficientOfThermalExpansion units, change base unit
  • Add picomoles and femtomoles
  • Restrict number extension methods to INumber
  • Remove checked-in tools requiring Git LFS
  • Add Length.Kilofoot unit
  • Add CoefficientOfThermalExpansion operators
  • Move unit abbreviation strings into culture-specific resource files
  • Fallback to invariant culture if cultures are not found
  • Add Speed / Acceleration operator
  • Add UnitsNetSetup to hold global static state
  • Add units to ElectricCurrentGradient, PressureChangeRate
  • Define base units for Pressure, PressureChangeRate
  • Add PerfTests for startup and JIT comparing v4 and v5
  • Fix whitespace in codegen
  • Add Quantity.From/TryFromUnitAbbreviationd
  • Added absorbed dose of ionizing radiation units
  • Add ImperialQuart to Volume
  • Add Equals() to IQuantity interfaces
  • Linear density enhancements
  • Add Operators Between Energy, ElectricCharge, and EletricPotential
  • Improve precision of ReciprocalLength.InverseMile
  • Add picograms and femtograms
  • Fix consistent ordering of units
  • README: Add link to Python package
  • Fix precision of gallon volume units
  • Publish test results to ADO pipeline
  • Add UsGallonsPerMile, ImperialGallonPerMile, MegaukGallonPerDay, MegausGallonPerDay
  • ToUnit for IValueQuantity should return IValueQuantit
  • Add MegalitersPerHour, MegalitersPerMinute, MegalitersPerSecond
  • Add LeakRate quantity
  • Fix quantity name in obsolete attributes
  • Add water column pressure units
  • Add IValueQuantity interface to expose the value type
  • Added Megameter (1e+6 meters)
  • Improve precision of Mass, Area units
  • Add UnitMath.Clamp(value, min, max)
  • Added more units
  • Added Femtoampere to ElectricCurrent
  • Added support for molar flow units
  • Descibe null checks in obsolete message for equality overloads
  • 1 mile is 1609.344
  • Add unit definition "MegaJoulePerTonne" to SpecificEnergy
  • Add Micro and Milli prefixes to Frequency
  • Add new Impulse quantity with relevant units
  • Update .NET nanoFramework NuGets (v4)
  • Improve nullable annotations for net7.0 multi-targeting
  • ci: Split into stages
  • Generic math for UnitsNet in .NET 7
  • Remove LapseRate quantity
  • QuantityValue.ToString(): Specify default culture
  • Enable deterministic builds
  • Remove obsolete Molarity units
  • azure-pipelines: Fix nuget push due to duplicates
  • update benchmarks to net6.0
  • Bump Newtonsoft.Json from 13.0.1 to 13.0.2 in /UnitsNet.Serialization.JsonNe
  • Bump Newtonsoft.Json from 13.0.1 to 13.0.2 in /CodeGen
  • Add nanoliter unit to Volume quantity
  • Add UnitMath.Clamp(value, min, max)
  • Fix concurrency issue when getting abbreviations
  • Add concurrency checks to UnitValueAbbreviationLookup
  • Add back IEquatable with strict equality
  • Fix path to msbuild components for .NET nanoFramework projects
  • Set up Azure Pipelines
  • Add EnergyDensity
  • Add units PetaJoule, TeraJoule
  • Use readonly for structs in QuantityGenerator
  • Return non-zero for trigger-js-release action failure
  • Bump NuGet.Protocol from 6.2.1 to 6.2.2 in /CodeGen
  • Integration with the JS package
  • AreaDensity: Add g/m2, mg/m2, add operators
  • Fix build hang by upgrading dotcover
  • Fix .NET nanoFramework build
  • Update .NET nanoFramework NuGets

@Jay-o-Way
Copy link
Collaborator

Was there any issue that discusses these changes or the need for it, perhaps?

@Jay-o-Way

This comment has been minimized.

@Jay-o-Way Jay-o-Way added the Needs-Review This Pull Request awaits the review of a maintainer. label Apr 22, 2024
@jaimecbernardo
Copy link
Collaborator

##[warning]C:\hostedtoolcache\windows\dotnet\sdk\8.0.204\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(284,5): Warning NETSDK1206: Found version-specific or distribution-specific runtime identifier(s): win10-arm64, win10-x64, win10-x86. Affected libraries: Microsoft.WindowsAppSDK. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.

This one is all around, I think.

@Jvr2022
Copy link
Author

Jvr2022 commented Apr 23, 2024

Was there any issue that discusses these changes or the need for it, perhaps?

for staying uptodate

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 23, 2024

I thought about doing this in the past too. And especially as it might add new units.

But I have in mind that it didn't do it because the new package has fundamental changes that break the plugin. @Jvr2022, please validate this and either update the code or create a tracking issue for updating that package later.

And btw. we meay need to update the plugin code to support the new units.

@Jvr2022
Copy link
Author

Jvr2022 commented Apr 23, 2024

I am gonna make this pr a draft and change to codes to make it compatibel @Jay-o-Way

@Jvr2022 Jvr2022 marked this pull request as draft April 23, 2024 09:57
@Jvr2022 Jvr2022 changed the title [DEPS] Update Unitsnet to 5.50.0 [DEPS] Update Unitsnet to 5.50.0 (wip) Apr 23, 2024
@Jvr2022
Copy link
Author

Jvr2022 commented Apr 23, 2024

@htcfreek @Jay-o-Way ready for review

@Jvr2022 Jvr2022 marked this pull request as ready for review April 23, 2024 11:51
@jaimecbernardo
Copy link
Collaborator

Similar to #27844 that you've opened before, it's not clear why this change is needed in the project. Can you please elaborate?

@htcfreek
Copy link
Collaborator

@jaimecbernardo
I aggre not completely. The updated dependency will allow us to support more additional units and may contain fixes. (Didn't read the complete change log.)

@Jvr2022
Copy link
Author

Jvr2022 commented Apr 24, 2024

@Jay-o-Way @jaimecbernardo this release have many bug Fixes and makes support for new units that we can use in the project. (And people dont like to see old version of deps)

@Jvr2022 Jvr2022 changed the title [DEPS] Update Unitsnet to 5.50.0 (wip) [DEPS] Update Unitsnet to 5.50.0 Apr 24, 2024
Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jvr2022
Copy link
Author

Jvr2022 commented Apr 25, 2024

And?

@htcfreek
Copy link
Collaborator

@Jvr2022
I do not have permission for a review that authorizes the merge.

@jaimecbernardo
Can you look at this and do the final review.

@jaimecbernardo
Copy link
Collaborator

Hi,
Would like to check all the changes on the dependency that's being updated first.
I like to be conservative with contributions that are not clear on what they're bringing for the project specifically.
Is this blocking any following work?
I'd prefer to leave this one for after the next release, which is when I'll have a bit more time to look in a more detailed way into it.
Thanks you for the contribution, but I hope you understand 😉

@htcfreek
Copy link
Collaborator

@jaimecbernardo

Is this blocking any following work?

No. Let's add a revisit label.

@Jvr2022
Copy link
Author

Jvr2022 commented Apr 27, 2024

Alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer. revisit-0.82.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants