New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEPS] Update Unitsnet to 5.50.0 #32572
base: main
Are you sure you want to change the base?
Conversation
Was there any issue that discusses these changes or the need for it, perhaps? |
This comment has been minimized.
This comment has been minimized.
This one is all around, I think. |
for staying uptodate |
I thought about doing this in the past too. And especially as it might add new units. But I have in mind that it didn't do it because the new package has fundamental changes that break the plugin. @Jvr2022, please validate this and either update the code or create a tracking issue for updating that package later. And btw. we meay need to update the plugin code to support the new units. |
I am gonna make this pr a draft and change to codes to make it compatibel @Jay-o-Way |
@htcfreek @Jay-o-Way ready for review |
Similar to #27844 that you've opened before, it's not clear why this change is needed in the project. Can you please elaborate? |
@jaimecbernardo |
@Jay-o-Way @jaimecbernardo this release have many bug Fixes and makes support for new units that we can use in the project. (And people dont like to see old version of deps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
And? |
@Jvr2022 @jaimecbernardo |
Hi, |
No. Let's add a revisit label. |
Alright |
changes