Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTRun] Remove full stops in plugin descriptions #32613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HydroH
Copy link
Contributor

@HydroH HydroH commented Apr 25, 2024

Summary of the Pull Request

Removed full stops in PowerToys Run plugin descriptions, and unified appearances of 'Examples' to 'e.g.' to make descriptions more consistent.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

image

@@ -202,7 +202,7 @@
<comment>'UTC' means here 'Universal Time Convention'</comment>
</data>
<data name="Microsoft_plugin_timedate_plugin_description" xml:space="preserve">
<value>Provides time and date values for the system time or a custom time stamp (Examples: '{0}', '{1}', '{2}', '{3}')</value>
<value>Provides time and date values for the system time or a custom time stamp (e.g.'{0}', '{1}', '{2}', '{3}')</value>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your image, there is no space in e.g.'Day' Do you happen to know why?

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Apr 25, 2024

Off-topic: I see you use ( for the time/date plugin. Some characters and phrases may conflict with global queries of other plugins if you use them as activation commands. For example, using ( breaks global calculation queries starting with an opening parenthesis. The default is changed to ).

@HydroH
Copy link
Contributor Author

HydroH commented Apr 25, 2024

Off-topic: I see you use ( for the time/date plugin. Some characters and phrases may conflict with global queries of other plugins if you use them as activation commands. For example, using ( breaks global calculation queries starting with an opening parenthesis. The default is changed to ).

Thanks for reminding! I never manually set this, I guess the default was changed sometime during updates?

@Jay-o-Way
Copy link
Collaborator

I guess the default was changed sometime during updates

It's been a while ago. But yes. It would be too much of a "breaking change" to actively change user's settings. So many people still have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants