Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSC] Add support for ImageresizerSizes property #32657

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DSC] Add support for ImageresizerSizes property #32657

wants to merge 1 commit into from
+301 −33

Conversation

yuyoyuppe
Copy link
Collaborator

Summary of the Pull Request

  • do not use ints for enums in ImageSize struct
  • add required converters
  • extend setAdditional functionality
  • add relevant sample

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • applied installAndConfiguration.dsc.yaml (with the install step commented out) and verified in the settings that the sizes are appended/changed
  • applied configureLauncherPlugins.dsc.yaml and verified that Launcher plugins configuration still works

@yuyoyuppe yuyoyuppe changed the title Add support for ImageresizerSizes property [DSC} Add support for ImageresizerSizes property Apr 29, 2024
@yuyoyuppe yuyoyuppe changed the title [DSC} Add support for ImageresizerSizes property [DSC] Add support for ImageresizerSizes property Apr 29, 2024
@yuyoyuppe
Copy link
Collaborator Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yuyoyuppe
Add support for ImageresizerSizes property
a99e62b 
- do not use ints for enums in ImageSize struct
- add required converters
- extend setAdditional functionality
- add samples
@yuyoyuppe yuyoyuppe force-pushed the add_imageresizer_sizes_support branch from d61f08d to a99e62b Compare April 29, 2024 14:11
@dfederm
Copy link
Member

dfederm commented Apr 30, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo Awaiting requested review from jaimecbernardo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuyoyuppe @dfederm