Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing files in Root dir #32659

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Apr 29, 2024

Summary of the Pull Request

I'm a big advocate of keeping the root dir as clean as possible. As moving items can be highly disruptive, this will be a slow process.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

.pipelines/applyXamlStyling.ps1 Outdated Show resolved Hide resolved
.pipelines/applyXamlStyling.ps1 Outdated Show resolved Hide resolved
crutkas and others added 2 commits April 29, 2024 13:35
Co-authored-by: Davide Giacometti <davide.giacometti@outlook.it>
Co-authored-by: Davide Giacometti <davide.giacometti@outlook.it>
@Jay-o-Way
Copy link
Collaborator

I'm a big advocate of keeping the root dir as clean as possible.

This feels a lot like a (personal) opinion. I don't think there's any problem with having these files at the root of the repo. Actually, I think they belong in their current place. These things are not part of the source for the app at all, they are circumstantial.

@htcfreek
Copy link
Collaborator

@crutkas
I know it's out of scoope. But I wonder if it makes sense to add the pipeline directory to the CODEOWNERS file for protection too.

@crutkas
Copy link
Member Author

crutkas commented Apr 30, 2024

I need to lock down other files too. But yeah, outside this

@crutkas
Copy link
Member Author

crutkas commented May 1, 2024

Trying to move a few more into this. I can't seem to get it quite right ...
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants