Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop outdated sln win-app-driver README.md file reference #32794

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop outdated sln win-app-driver README.md file reference #32794

wants to merge 1 commit into from
+0 −5

Conversation

Kissaki
Copy link
Contributor

@Kissaki Kissaki commented May 9, 2024 •
edited

Summary of the Pull Request

PR #29453 removed the src/tests/win-app-driver folder, but missed removing the sln file reference to the folders README.md file.

Remove the outdated file reference.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Manually: Opened Solution in VS. Trying to open README.md fails with missing file. After this change, the file is no longer listed.

@Kissaki
Copy link
Contributor Author

Kissaki commented May 9, 2024

I didn't create a ticket for discussion because the change seems obvious and minimal to me.

With that, nothing of the checklist applies either.

@Kissaki
Drop outdated sln win-app-driver README.md file reference
2cb558c 
PR microsoft#29453 removed the `src/tests/win-app-driver` folder, but missed removing the sln file reference to the folders `README.md` file.
@Kissaki Kissaki changed the title Drop outdated sln win-app-driver README.d file reference Drop outdated sln win-app-driver README.md file reference May 9, 2024
SeraphimaZykova
SeraphimaZykova approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeraphimaZykova SeraphimaZykova SeraphimaZykova approved these changes

@jaimecbernardo jaimecbernardo Awaiting requested review from jaimecbernardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kissaki @SeraphimaZykova